Draft
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One half of this PR:
https://ono.unity3d.com/unity/unity/pull-request/139252/_/graphics/update-physical-camera
Purpose of this PR
This PR migrates a number of settings from HDRP down into core unity camera class so they can be shared between URP and HDRP. The change includes data upgraders and updated UI that is shared between URP and HDRP.
Testing status
Covered via automated testing.
Comments to reviewers
Needs to be reviewed in conjunction with:
https://ono.unity3d.com/unity/unity/pull-request/139252/_/graphics/update-physical-camera